diff --git a/src/config.h b/src/config.h index da902c4..a2001ac 100644 --- a/src/config.h +++ b/src/config.h @@ -13,7 +13,7 @@ #define VERSION "1.2.0-master" -#define BUILD 934 +#define BUILD 935 #define HOSTID "mailarchiver" diff --git a/src/counters.c b/src/counters.c index 65c27d4..5589672 100644 --- a/src/counters.c +++ b/src/counters.c @@ -94,7 +94,7 @@ //if(cfg->verbosity >= _LOG_DEBUG) syslog(LOG_PRIORITY, "%s: update counters: %s", sdata->ttmpfile, buf); - p_query(sdata, buf, cfg); + p_query(sdata, buf); } } @@ -119,7 +119,7 @@ if(counters->c_virus + counters->c_duplicate + counters->c_ignore + counters->c_size + counters->c_stored_size <= 0) return; snprintf(buf, SMALLBUFSIZE-1, "UPDATE `%s` SET `rcvd`=`rcvd`+%llu, `virus`=`virus`+%llu, `duplicate`=`duplicate`+%llu, `ignore`=`ignore`+%llu, `size`=`size`+%llu, `stored_size`=`stored_size`+%llu", SQL_COUNTER_TABLE, counters->c_rcvd, counters->c_virus, counters->c_duplicate, counters->c_ignore, counters->c_size, counters->c_stored_size); - p_query(sdata, buf, cfg); + p_query(sdata, buf); #ifdef HAVE_MEMCACHED } diff --git a/src/import.c b/src/import.c index 174a777..62ab31f 100644 --- a/src/import.c +++ b/src/import.c @@ -183,7 +183,7 @@ snprintf(buf, sizeof(buf)-1, "update import set status=%d, started=%ld, updated=%ld, finished=%ld, total=%d, imported=%d where id=%d", data->import->status, data->import->started, data->import->updated, data->import->finished, data->import->total_messages, data->import->processed_messages, data->import->import_job_id); - p_query(sdata, buf, cfg); + p_query(sdata, buf); } diff --git a/src/mysql.c b/src/mysql.c index 4cb03cd..480fbec 100644 --- a/src/mysql.c +++ b/src/mysql.c @@ -47,7 +47,7 @@ } -void p_query(struct session_data *sdata, char *s, struct __config *cfg){ +void p_query(struct session_data *sdata, char *s){ mysql_real_query(&(sdata->mysql), s, strlen(s)); } diff --git a/src/parser_utils.c b/src/parser_utils.c index 5812ed7..f5720cb 100644 --- a/src/parser_utils.c +++ b/src/parser_utils.c @@ -451,7 +451,7 @@ if(strlen(state->miscbuf) > 0){ memset(puf, 0, sizeof(puf)); - strncpy(puf, state->miscbuf, sizeof(puf)-1); + strncpy(puf, state->miscbuf, sizeof(puf)-strlen(puf)-1); strncat(puf, buf, sizeof(puf)-strlen(puf)-1); memset(buf, 0, MAXBUFSIZE); @@ -750,7 +750,7 @@ fixed_url[len-1] = '\0'; } - snprintf(buf, buflen, "%s", fixed_url); + snprintf(buf, buflen, "%s", fixed_url); } diff --git a/src/pilerpurge.c b/src/pilerpurge.c index 36b5699..a259972 100644 --- a/src/pilerpurge.c +++ b/src/pilerpurge.c @@ -92,7 +92,7 @@ if(dryrun == 1){ printf("running sql query: *%s*\n\n", update_meta_sql); } else { - p_query(sdata, update_meta_sql, cfg); + p_query(sdata, update_meta_sql); } @@ -191,7 +191,7 @@ if(dryrun == 1){ printf("delete sql: *%s*\n", delete_attachment_stmt); } else { - p_query(sdata, delete_attachment_stmt, cfg); + p_query(sdata, delete_attachment_stmt); } } @@ -224,7 +224,7 @@ if(dryrun == 1){ printf("delete sql: *%s*\n", delete_attachment_stmt); } else { - p_query(sdata, delete_attachment_stmt, cfg); + p_query(sdata, delete_attachment_stmt); } } @@ -404,7 +404,7 @@ if(purged_size > 100){ snprintf(buf, sizeof(buf)-1, "UPDATE `%s` SET size = size - %ld", SQL_COUNTER_TABLE, purged_size); - if(dryrun == 0) p_query(&sdata, buf, &cfg); + if(dryrun == 0) p_query(&sdata, buf); } diff --git a/src/smtp.c b/src/smtp.c index 7ed7b58..1f63dd4 100644 --- a/src/smtp.c +++ b/src/smtp.c @@ -27,7 +27,7 @@ if(sdata->tls == 0) snprintf(tmpbuf, sizeof(tmpbuf)-1, SMTP_RESP_250_EXTENSIONS, cfg->hostid, data->starttls); else snprintf(tmpbuf, sizeof(tmpbuf)-1, SMTP_RESP_250_EXTENSIONS, cfg->hostid, ""); - strncat(resp, tmpbuf, resplen); + strncat(resp, tmpbuf, resplen-strlen(resp)); } diff --git a/src/sql.h b/src/sql.h index e57671f..07c214c 100644 --- a/src/sql.h +++ b/src/sql.h @@ -9,7 +9,7 @@ int open_database(struct session_data *sdata, struct __config *cfg); void close_database(struct session_data *sdata); int prepare_sql_statement(struct session_data *sdata, MYSQL_STMT **stmt, char *s, struct __config *cfg); -void p_query(struct session_data *sdata, char *s, struct __config *cfg); +void p_query(struct session_data *sdata, char *s); int p_exec_query(struct session_data *sdata, MYSQL_STMT *stmt, struct __data *data); int p_store_results(struct session_data *sdata, MYSQL_STMT *stmt, struct __data *data); int p_fetch_results(MYSQL_STMT *stmt); diff --git a/unit_tests/check_mydomains.c b/unit_tests/check_mydomains.c index 19c42ed..28b4fac 100644 --- a/unit_tests/check_mydomains.c +++ b/unit_tests/check_mydomains.c @@ -42,7 +42,7 @@ for(i=0; i